Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork message_notify_eca-3459764

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

SocialNicheGuru created an issue. See original summary.

Rohan_Singh made their first commit to this issue’s fork.

Rohan_Singh opened merge request !3

rohan_singh’s picture

rohan_singh commented

@akalam and @tonibarbera, I have raised a PR for the ECA 2.x support. Kindly review and merge this.

rohan_singh’s picture

rohan_singh commented
Status: Active » Needs review
monkk’s picture

monkk commented

This will allow to install module, but I don't think it will go further than that.
At least I get below error:
ECA ran into error from third party in the context of "Collecting all available actions": Cannot override final method Drupal\eca\Plugin\Action\ActionBase::__construct() Line 35 of /Applications/MAMP/htdocs/test/web/modules/message_notify_eca/src/Plugin/Action/MessageNotify.php

Seems __construct() needs to be rewritten, but haven't solved it yet.

socialnicheguru’s picture

socialnicheguru commented
Status: Needs review » Needs work

tonibarbera made their first commit to this issue’s fork.

tonibarbera opened merge request !4

tonibarbera closed merge request !4

  • tonibarbera committed 84614d4f on 1.0.x 
    Issue #3459764: Update message_notify_eca to use eca 2.x
tonibarbera’s picture

tonibarbera commented

I've updated the constructor. It should work now with Drupal 10.3

tonibarbera’s picture

tonibarbera commented
Status: Needs work » Needs review

  • tonibarbera committed 08ceaeb0 on 1.0.x 
    Issue #3459764: Update message_notify_eca to use eca 2.x

  • akalam committed c9bd5220 on 1.0.x 
    Issue #3459764: Update message_notify_eca to use eca 2.x
akalam’s picture

akalam commented
Status: Needs review » Fixed
akalam’s picture

akalam commented

@monkk the constructor is declared as final on ActionBase on ECA v2, so it can't be overridden. We have removed that override and used an alternative method for dependency injection.
This should be fine in beta5.
Thanks for reporting

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.