Problem/Motivation

Currently only including channels is possible, but it would be helpful to also have the other way around option, if you'd like to receive ALL channels EXCLUDING certain ones.

So I think we should simply use a boolean to turn it around, like Drupal also allows in other places.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork watchdog_mailer-3457869

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Anybody created an issue. See original summary.

lrwebks’s picture

lrwebks commented
Assigned: Unassigned » lrwebks
Status: Active » Needs work

Starting on this now!

LRWebks opened merge request !26

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

As field description for the checkbox please use something like:
"When checked, the given channels will be excluded instead of being included"

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue tags: +Needs tests

Can we have an additional WatchdogMailerMailTest test for the exclude functionality?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Re: #4 the current description is already fine, sorry. I didn't see that.
You may decide to keep it as-is!

lrwebks’s picture

lrwebks commented
Status: Needs work » Needs review

Everything's implemented and ready now! (Also implemented the Test, thanks for the reminder!)

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: lrwebks » Unassigned
Status: Needs review » Reviewed & tested by the community

Great! :)

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

  • Anybody committed 7d1d3ebe on 3.x authored by LRWebks 
    Issue #3457869 by LRWebks, Anybody: Allow including and excluding...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.