We are receiving PHP warnings for:

Trying to access array offset on value of type bool in DrupalPathinc->path_delete() (line 475 of /pathinc/DrupalPathinc.class.inc).

Having dug deeper into this, it would appear that Drupal core has extra checks in path_delete, which do not exist in this module.

We should patch accordingly.

Issue fork pathinc-3457205

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

colinstillwell created an issue. See original summary.

abhishek_gupta1’s picture

abhishek_gupta1 commented
Assigned: Unassigned » abhishek_gupta1

abhishek_gupta1 opened merge request !1

abhishek_gupta1’s picture

abhishek_gupta1 commented
Assigned: abhishek_gupta1 » Unassigned
Status: Active » Needs review

@colinstillwell,. I have fixed the issue and created MR. please review it once.

colinstillwell opened merge request !2

colinstillwell’s picture

colinstillwell commented

@abhishek_gupta1 I am not sure I agree with the changes. I would have just copied what is already in Drupal core, for consistency. This should avoid confusion in the future.

I have just created my own MR, to demonstrate my point.

steven jones’s picture

steven jones commented
Status: Needs review » Reviewed & tested by the community

I agree with @colinstillwell here, but thanks both for the MRs and this issue.

steven jones’s picture

steven jones commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.