According to the DAP documentation YouTube tracking via the yt parameter is disabled by default. But the module gives the yt parameter a default of true. usfedgov_google_analytics_library_info_build() then strips any parameters with the defaults out of the query string. In other words, a yt set to true gets removed. So if someone wants YouTube tracking to be enabled, then they have no way to turn it on.

This same problem may apply to other settings with defaults of true. I haven't checked yet.

Issue fork usfedgov_google_analytics-3457038

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dcam created an issue. See original summary.

dcam opened merge request !10

  • dcam committed 0442770f on 2.x 
    Issue #3457038 by dcam: Fix the YouTube tracking setting
dcam’s picture

dcam commented
Status: Active » Fixed

I'm not going to worry about the other settings with true defaults right now. One of them defaults to true in DAP. The other two aren't documented anymore, making me think they may need to be removed. The entire array of settings and the form needs to be overhauled anyway.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.