Support Drupal 10.3 SDC deprecation

Attach a patch for the fix

I was facing this error:

TypeError: Drupal\cl_editorial\NoThemeComponentManager::__construct(): Argument #1 ($pluginManager) must be of type Drupal\sdc\ComponentPluginManager, Drupal\Core\Theme\ComponentPluginManager given, called in /var/www/docroot/core/lib/Drupal/Component/DependencyInjection/Container.php on line 261 in Drupal\cl_editorial\NoThemeComponentManager->__construct() (line 23 of modules/contrib/cl_editorial/src/NoThemeComponentManager.php).

The MR code solved the error.

Sorry, I moved to RTBC too soon.

I'm now facing a different error when I access "Manage Display" tab on the Basic Page CT:

AssertionError: assert($component_manager instanceof ComponentPluginManager) in assert() (line 58 of modules/contrib/sdc_display/sdc_display.module).
sdc_display_field_formatter_third_party_settings_form(Object, Object, 'default', Array, Object) (Line: 162)
Drupal\field_ui\Form\EntityViewDisplayEditForm->Drupal\field_ui\Form\{closure}(Object, 'sdc_display') (Line: 396)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('field_formatter_third_party_settings_form', Object) (Line: 168)
Drupal\field_ui\Form\EntityViewDisplayEditForm->thirdPartySettingsForm(Object, Object, Array, Object) (Line: 451)
Drupal\field_ui\Form\EntityDisplayFormBase->buildFieldRow(Object, Array, Object) (Line: 41)
Drupal\field_ui\Form\EntityViewDisplayEditForm->buildFieldRow(Object, Array, Object) (Line: 227)
Drupal\layout_builder\Form\LayoutBuilderEntityViewDisplayForm->buildFieldRow(Object, Array, Object) (Line: 213)
Drupal\field_ui\Form\EntityDisplayFormBase->form(Array, Object) (Line: 47)

I just realized that the error is not on cl_editorial, and it is, in fact, on sdc_display.

Created an issue here: https://www.drupal.org/project/sdc_display/issues/3458639

Moving to "Needs review" for some other community members to review the patch provided if they use cl_editorial only.

I was facing this error #4 too en Drupal 10.3, and #3 patch solved the error.

Note for anyone who needs to know how to apply the patches, add these patches to composer.json:

    "extra": {
    ...
        "patches": {
            "drupal/cl_editorial": {
                "#3456850: Support Drupal 10.3 SDC deprecation": "https://git.drupalcode.org/project/cl_editorial/-/merge_requests/12.patch"
            }
        },
    },

And execute:

composer update drupal/cl_editorial

See the doc https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr...

posted a comment - re: applying the above patch - in the wrong place, so I deleted it and reentered at
https://www.drupal.org/project/sdc_display/issues/3458639

Can we release a new version with this patch so this module work in Drupal 10.3 out of the box?

Thank you, for the MR12 and the static patch file.
It's working.
Using the static patch file with Composer Patches, which identical of MR12

Hello @rajab. Out of curiosity, why do you use a static version of the patch and not the MR version as I suggested in #8? The MR version may make it more unstable, but it will include the latest changes from the patch which should be good. Is it because of this instability that you prefer the static version?

Gastón, nice to ask. I think you got it right.

This is a better practice rule for patching in my company.

Thanks Rajab, perfect make sense.

I think this should grant a 3.x branch that requires drupal >10.3

Many thanks to all, I've now released a 3.x version and tagged a rc with this.

@pcambra super! thanks to all.

This should also be done in submodule sdc_tags.

And maybe in module sdc_block to solve this issue? https://www.drupal.org/project/sdc_block/issues/3456851

The merge request contains the change on 2.x to update core_version_requirement in sdc_tags. A similar change should also be done in 3.x.

Does this actually work in Drupal 9? If not, core_version_requirement should not declare that compatibility.

One at at a time, thanks heddn.

@liam morland, thanks for noticing that, I've pushed a 3.0.0-rc2 tag with this.