Problem/Motivation

On line 42 of the umami.theme, this class should be added as a new item in the array. Right now it’s stepping on any other classes in that array.

Proposed resolution

Add [] after the class to add 'label-items' as a new item in the array.

Issue fork drupal-3454274

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Lillian Bozeman created an issue. See original summary.

markconroy’s picture

markconroy commented

Thanks for posting this issue @Lillian Bozeman.

I'll get a fix for it asap.

markconroy’s picture

markconroy commented

===
Thanks to Code Enigma for sponsoring my time to work on this.

markconroy opened merge request !8414

markconroy’s picture

markconroy commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Title: Don't step on all of the other classes. » Classes array in preprocess_field hook are overridden
Status: Needs review » Reviewed & tested by the community

Seems pretty straight froward.

Re-ran the failing tests and they're passing.

Tweaked the title some.

quietone’s picture

quietone commented
Title: Classes array in preprocess_field hook are overridden » Do not override class in preprocess_field hook
Category: Task » Bug report

I read the issue summary, comments and the MR. There are no question here, so nothing is unanswered. :-)

This seems like a bug to me.

  • alexpott committed 187c2bf4 on 10.3.x 
    Issue #3454274 by markconroy, Lillian Bozeman: Do not override class  in...

  • alexpott committed cfeb5be4 on 10.4.x 
    Issue #3454274 by markconroy, Lillian Bozeman: Do not override class  in...

  • alexpott committed 09db6d08 on 11.0.x 
    Issue #3454274 by markconroy, Lillian Bozeman: Do not override class  in...

  • alexpott committed 238082ab on 11.x 
    Issue #3454274 by markconroy, Lillian Bozeman: Do not override class  in...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 238082ab82 to 11.x and 09db6d0852 to 11.0.x and cfeb5be479 to 10.4.x and 187c2bf4b3 to 10.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.