Problem/Motivation

When checking to see if the databases array exists, we check isset($databases) but we really need to be checking to see if the default key exists within the database as the default settings.php file includes a completely empty $databases array by default. So it is set, but doesn't have keys.

Steps to reproduce

Install drupal/mysql57, follow documented steps to require settings.inc and use drush site:install to attempt installation.

Proposed resolution

Add additional check for if databases default key is present.

Issue fork mysql57-3453759

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

eporama created an issue. See original summary.

eporama opened merge request !1

eporama’s picture

eporama commented
Status: Active » Needs review

I created a quick MR that simply checks to also see if the default database role is available as an array key.

effulgentsia made their first commit to this issue’s fork.

effulgentsia’s picture

effulgentsia commented
Status: Needs review » Fixed

Thanks! Merged, and will tag beta3 with it shortly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.