Problem/Motivation
At the moment the module uses the generic access administration pages permission from Drupal core to restrict access to /admin/config/content/elb. In some site implementations it is desirable to have a distinct permission to limit access to the ELB settings.
Steps to reproduce
Add the permission access administration pages to a user that has no access to other pages that touch Drupal configuration, for example. Witness the menu item appear for users in that role.
Proposed resolution
Add a distinct permission dedicated for administering the settings of this module only.
Remaining tasks
- Add the elb.permissions.yml file with the correct permission
- Switch the permission used in elb.routing.yml for route elb.ext_link_blocklist_settings_form
- (optional) write an update hook implementation in elb.install that adds the new permission to all roles that have the previous permission
User interface changes
None
API changes
None
Data model changes
None
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | Screenshot 2024-06-10 at 3.05.07 PM.png | 124.08 KB | kalpanajaiswal |
| #5 | Screenshot 2024-06-10 at 3.05.20 PM.png | 106.72 KB | kalpanajaiswal |
| #5 | Screenshot 2024-06-10 at 3.00.21 PM.png | 128.47 KB | kalpanajaiswal |
Issue fork elb-3453591
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
kalpanajaiswal commentedMR has been created and covering all the points mentioned in remaining tasks.
Comment #5
kalpanajaiswal commentedAdding few screenshots after testing in my local setup.
Comment #6
kekkis@kalpanajaiswal, thanks for your contribution! As I mention in the MR comment, I don't see value in adding a .gitlab-ci.yml that is so generic it only runs
sleep. I would suggest we remove it from the MR branch.Comment #7
kalpanajaiswal commentedAs per the suggestion .gitlab-ci.yml is removed from the commit.
Comment #8
kalpanajaiswal commentedComment #10
kekkisThanks, committed to 2.1.x!