Problem/Motivation

At the moment the module uses the generic access administration pages permission from Drupal core to restrict access to /admin/config/content/elb. In some site implementations it is desirable to have a distinct permission to limit access to the ELB settings.

Steps to reproduce

Add the permission access administration pages to a user that has no access to other pages that touch Drupal configuration, for example. Witness the menu item appear for users in that role.

Proposed resolution

Add a distinct permission dedicated for administering the settings of this module only.

Remaining tasks

  • Add the elb.permissions.yml file with the correct permission
  • Switch the permission used in elb.routing.yml for route elb.ext_link_blocklist_settings_form
  • (optional) write an update hook implementation in elb.install that adds the new permission to all roles that have the previous permission

User interface changes

None

API changes

None

Data model changes

None

Issue fork elb-3453591

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

kekkis created an issue. See original summary.

kalpanajaiswal made their first commit to this issue’s fork.

kalpanajaiswal’s picture

MR has been created and covering all the points mentioned in remaining tasks.

kalpanajaiswal’s picture

Adding few screenshots after testing in my local setup.

kekkis’s picture

@kalpanajaiswal, thanks for your contribution! As I mention in the MR comment, I don't see value in adding a .gitlab-ci.yml that is so generic it only runs sleep. I would suggest we remove it from the MR branch.

kalpanajaiswal’s picture

As per the suggestion .gitlab-ci.yml is removed from the commit.

kalpanajaiswal’s picture

Status: Active » Needs review

kekkis’s picture

Status: Needs review » Fixed

Thanks, committed to 2.1.x!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.