Problem/Motivation

CKEditor 5 has renamed a CSS variable from --ck-z-modal to --ck-z-panel which causes a previous fix for issue #3274937 in core/modules/ckeditor5/ckeditor5.dialog.fix.css to fail to apply. As a result, CKEditor 5 dialogs may incorrectly appear behind jQuery UI dialogs.

Proposed resolution

Rename the variable in core/modules/ckeditor5/ckeditor5.dialog.fix.css to --ck-z-panel to match the CKEditor 5 change.

Issue fork drupal-3453320

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

timurtripp created an issue. See original summary.

timurtripp’s picture

timurtripp commented
Issue summary: View changes

timurtripp opened merge request !8338

timurtripp’s picture

timurtripp commented
Status: Needs work » Needs review
timurtripp’s picture

timurtripp commented
Title: [10.3 regression] CKEditor 5 renamed CSS variable causing dialogs to fail to appear » [10.3 regression] CKEditor 5 renamed CSS variable causing CKEditor dialogs to fail to appear above jQuery UI dialogs
catch’s picture

catch
he/him
Primary language English
commented
Parent issue: » #3409178: [meta] Release preparation steps for 10.3.0
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Seems straight forward. but can MR be updated for 11.x please.

timurtripp closed merge request !8338

timurtripp opened merge request !8415

timurtripp’s picture

timurtripp commented
Version: 10.3.x-dev » 11.x-dev

Done.

timurtripp’s picture

timurtripp commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Thanks

  • alexpott committed 16267872 on 10.3.x 
    Issue #3453320 by timurtripp: [10.3 regression] CKEditor 5 renamed CSS...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +Needs followup

Committed and pushed 703830324b to 11.x and c6702c5ed9 to 11.0.x and b4ffe7ef4b to 10.4.x and 162678726c to 10.3.x. Thanks!

It might be great if there was a test somewhere for this. I didn't make it a requirement for merging because of the regression but given we have CSS to address the issue and we integrate ckeditor and jQuery perhaps a test is worth it.

  • alexpott committed b4ffe7ef on 10.4.x 
    Issue #3453320 by timurtripp: [10.3 regression] CKEditor 5 renamed CSS...

  • alexpott committed c6702c5e on 11.0.x 
    Issue #3453320 by timurtripp: [10.3 regression] CKEditor 5 renamed CSS...

  • alexpott committed 70383032 on 11.x 
    Issue #3453320 by timurtripp: [10.3 regression] CKEditor 5 renamed CSS...
foxy-vikvik’s picture

foxy-vikvik commented
Status: Fixed » Needs work

It is still not fixed.

kksandr’s picture

kksandr commented

.ui-dialog ~ .ck-body-wrapper
This does not solve the problem if an instance of CKEditor was already placed on the page and after that the dialog was opened. Then .ck-body-wrapper will be before .ui-dialog

kksandr’s picture

kksandr commented

I suggest overriding the --ck-z-panel variable without additional conditions

kksandr’s picture

kksandr commented
Status: Needs work » Fixed
Related issues: +#3328425: CKEditor 5 balloons invisible when CKEditor 5 is used inside a modal

Work on the issue I mentioned in #19 continues here https://www.drupal.org/project/drupal/issues/3328425 so I return the status to "Fixed" since the original issue has been fixed, the variable has been renamed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone’s picture

quietone commented
Version: 11.x-dev » 10.3.x-dev

Update version to the branch this applies to.