Problem/Motivation

Currently, there is still a composer requirement for drupal/fakeobjects. Even though it is no longer needed for version 3.x.

Proposed resolution

The "drupal/fakeobjects" requirement should be removed from the composer.json for version 3.x.

CommentFileSizeAuthor
#3 remove-fakeobjects-requirement-3451579-3.patch653 byteschewi3

Issue fork ckeditor_iframe-3451579

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3.0.x Comparecompare
About issue forks

Comments

Chewi3 created an issue. See original summary.

chewi3’s picture

chewi3 commented
Assigned: Unassigned » chewi3
chewi3’s picture

chewi3 commented
Status: Active » Needs review
StatusFileSize
new remove-fakeobjects-requirement-3451579-3.patch653 bytes

Pushed proposed change to fork and also uploading a patch in case someone needs it. Please review.

chewi3’s picture

chewi3 commented
Assigned: chewi3 » Unassigned

  • 21dc74c2 committed on 3.0.x 
    Issue #3451579: Remove drupal/fakeobjects composer requirement for 3.x
bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented

Ah, yeah. Thanks! Committed and released 3.0.0-beta1

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented

Ugh, sorry, forgot to add you as a contributor to that commit before I made it. My email was screwed up on it too so... no one gets credit. Sigh.

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.