Problem/Motivation

Currently the javascript is loaded inline via the module file, however, according to Drupal standards this should be loaded via a separate javascript file.

Proposed resolution

The javascript code should be moved into a dedicated javascript file and imported into the module via the libraries and module files. A patch will follow below that does this.

Remaining tasks

Review and testing by the community.

CommentFileSizeAuthor
#2 move_inline_javascript_into_its_own_file-3451515-2.patch3.03 KBroaldnel

Comments

roaldnel created an issue. See original summary.

roaldnel’s picture

roaldnel commented
Status: Active » Needs review
StatusFileSize
new move_inline_javascript_into_its_own_file-3451515-2.patch3.03 KB

The patch is attached as promised.

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Needs review » Reviewed & tested by the community

  • roaldnel committed 944b02f9 on 1.0.x 
    Issue #3451515 by roaldnel: Move inline javascript into its own file
roaldnel’s picture

roaldnel commented
Version: 1.0.x-dev » 1.0.5
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.