Problem/Motivation
We have defaults for the Drupal core scope and identifier all over, example:
public function getItem(string $scope = AccessPolicyInterface::SCOPE_DRUPAL, string|int $identifier = AccessPolicyInterface::SCOPE_DRUPAL): CalculatedPermissionsItemInterface|false;
But we do not in removeItem():
public function removeItem(string $scope, string|int $identifier): self;
Let's fix this, ideally before we ship 10.3
Steps to reproduce
try to use the API, see that you need to be verbose when calling removeItem();
Proposed resolution
Apply AccessPolicyInterface::SCOPE_DRUPAL defaults to removeItem()
Remaining tasks
Apply AccessPolicyInterface::SCOPE_DRUPAL defaults to removeItem()
User interface changes
/
API changes
AccessPolicyInterface::SCOPE_DRUPAL default on removeItem()
Data model changes
/
Release notes snippet
/
Issue fork drupal-3450890
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
kristiaanvandeneyndeSetting to major for time sensitivity with D10.3-rc1 releasing next week.
Comment #5
kristiaanvandeneyndeNo clue why 11.0.x is failing on spellcheck
Comment #9
smustgrave commentedSo seems straight forward but the MR be pointed to 11.x vs 11.0.x
Comment #11
kristiaanvandeneyndeDone, we have one for 10.3.x, 11.0.x and 11.x now. No clue which one I should actually use by default to be honest.
Comment #12
smustgrave commented11.x I believe is still considered "main" so should land there first and then can be backported.
Thanks for making that change. tests are all green.
Comment #13
nod_Let's avoid using sane, it does not mean anything relevant here.
Comment #14
nicxvan commentedComment #15
nicxvan commentedComment #16
nicxvan commentedI updated the issue summary.
Comment #17
catchCommitted/pushed to 11.x, cherry-picked back through to 10.3.x, thanks!