Based on the issue: https://www.drupal.org/project/themed_fast_404/issues/3421496 to use the system 404 path to theme the 404 page. We've added some extra options to the configuration form choose wether you would like to generate the html based on the system 404 page settings, or use the themed_fast_404 configuration.

Also we've moved the functionality to generate the 404 html from the cron to the form.

We've also moved some code to the ThemedFast404Manager class.

CommentFileSizeAuthor
#2 Screenshot 2024-05-30 100542.png78.9 KBkensae
#2 Screenshot 2024-05-30 100608.png68.23 KBkensae

Issue fork themed_fast_404-3450805

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kensae created an issue. See original summary.

kensae’s picture

kensae commented
StatusFileSize
new Screenshot 2024-05-30 100608.png68.23 KB
new Screenshot 2024-05-30 100542.png78.9 KB

kensae opened merge request !14

kensae’s picture

kensae commented
Status: Active » Needs review
g_miric’s picture

g_miric commented
Status: Needs review » Needs work

@kensae Amazing. Thanks a lot!

The PR looks good. I requested some changes. Please ping me if you need help or if you have no time to implement them and I will do it.

  • bd37af59 committed on 3450805-make-the-404 
    #3450805: Make the 404 page more configurable
g_miric’s picture

g_miric commented
Status: Needs work » Needs review
g_miric’s picture

g_miric commented
Status: Needs review » Reviewed & tested by the community

  • g_miric committed eddc0f1b on 1.0.x authored by kensae 
    Issue #3450805 by kensae, g_miric: Make the 404 page more configurable
g_miric’s picture

g_miric commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.