Problem/Motivation

The personalization_storage variable has a typo.

Steps to reproduce

Proposed resolution

Refactor to "personalization_storage" and refactor all instances of "personalisation" to "personalization".

Remaining tasks

Write an update-hook to convert the variable value to the proper key.

User interface changes

None

API changes

None

Data model changes

Corrected variable name / constant name.

CommentFileSizeAuthor
personalization-typo-fix.patch6.19 KBnightlife2008
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

nightlife2008 created an issue. See original summary.

sourav_paul’s picture

Assigned: Unassigned » sourav_paul

nightlife2008’s picture

Issue summary: View changes
matthiasm11’s picture

Status: Active » Needs review
andreasderijcke’s picture

If anyone can add the update hook, this can be released faster. I might not get to it before wednesday.

sourav_paul’s picture

Assigned: sourav_paul » Unassigned
Issue summary: View changes
Issue tags: +typos

I've created a MR for this one..

@Maintainers pls review this.

andreasderijcke’s picture

@Sourav_Paul Are you able to add update hook too, for potential installs that already have config on the wrong config key?

sourav_paul’s picture

Assigned: Unassigned » sourav_paul
Status: Needs review » Needs work

@andreasderijcke Working on it.

sourav_paul’s picture

Assigned: sourav_paul » Unassigned
Status: Needs work » Needs review

@andreasderijcke I've added update hook, Could you please merge it?

andreasderijcke’s picture

Assigned: Unassigned » andreasderijcke

andreasderijcke’s picture

andreasderijcke’s picture

@Sourav_Paul Some feedback:

  • I'm not sure how, but you have seemed to have overwritten the first commit on the merge request with the second. Following the git commands here on on the MR itself, it should be no problem to add commits to an existing MR. Something to double check in the future.
  • About the update hook, 2 aspects:
    • The convention is to keep update hooks in the .install file, not .module and follow the existing update hook numbering unless to indicate major version jumps, which is not the case here.
      So the last one was 10001, so this one becomes 10002 and not 11001.
    • Update hook code itself was good, just didn't take possible language override into account.

In anyway, thanks for helping out.

@nightlife2008, thanks for reporting and patch.

andreasderijcke’s picture

Assigned: andreasderijcke » Unassigned
Status: Needs review » Fixed
sourav_paul’s picture

Thanks @andreasderijcke for your feedback, I'll keep this in mind for future.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.