Problem/Motivation
The explorer's legibility is not optimal. The contrast of the colours used on the component tree and the indentation should be reviewed to make it easier to read.
In addition, the ‘Modules’ or ‘Themes’ section is still displayed even though it contains no components. This feature therefore needs to be improved.
Proposed resolution
A CSS modification has been made to force the text in the component tree to be white. Indentation has been added to make sub-modules easier to read and understand.
A change has also been made to the way the tree is generated in the controller. The initial state of the tree automatically included the notions of ‘Themes’ and ‘Modules’; it is not mandatory to declare them, knowing that they will necessarily be added later by the components found.
Issue fork sdc_styleguide-3450020
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3450020-sdc_styleguide_explorer_improve
changes, plain diff MR !4
Comments
Comment #3
alemadleiThank you for your interest in helping out.
There's a correction that needs to take place however.
This is changing CSS indentation which goes against formatting guidelines (2 spaces).
https://www.drupal.org/docs/develop/standards/css/css-formatting-guidelines
Comment #5
anjali mehta commentedComment #7
alemadlei@Anjali, based on your initial comment about unnecesary groups I came up with the idea to use the grouping attribute of an SDC and instead the tree now is built using that grouping. This allowed me to simplify the structure.
The CSS has been updated so that that it overrides some of the styles that the rendering theme is using, however, the theme always has capabilities to change those. In general readability should be improved, but let me know your thoughts.
These updates have made your MR to have conflicts though.
Please raise a new issue if you find any problems.
Comment #8
alemadlei