Problem/Motivation

The GitLab pipeline shows failures in phpstan.

Steps to reproduce

  • Visit a recent GitLab build
  • Notice that the phpstan job has failed

Proposed resolution

Fix the errors found, or add ignore comment if there is a reason to. We 'll want to give some attention to the max PHP version errors as well, and decide if we want to address those.

Remaining tasks

  • Analyse the failiures
  • Fix the issues
  • Set the GitLab job to hard fail
  • Review
  • Merge
  • Inspect phpstan (max PHP version) results and create a follow-up issue if needed

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork fragments-3447537

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

eelkeblok created an issue. See original summary.

eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Issue summary: View changes

Amandeep123 made their first commit to this issue’s fork.

Amandeep123 changed the visibility of the branch 3447537-fixing_phpstan_issues to hidden.

eelkeblok opened merge request !23

eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Status: Active » Needs review

  • eelkeblok committed 39fdea3a on 2.x 
    Issue #3447537 by eelkeblok: Fix phpstan issues

eelkeblok opened merge request !24

  • eelkeblok committed e98ed42c on 2.x 
    Issue #3447537 by eelkeblok: Fix phpstan issues
eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Status: Needs review » Fixed
eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Issue tags: +ddd2025

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.