Problem/Motivation

The GitLab pipeline shows failures in cspell.

Steps to reproduce

  • Visit a recent GitLab build
  • Notice that the cspel job has failed

Proposed resolution

Fix the errors found, or add ignore comment if there is a reason to

Remaining tasks

  • Analyse the failiures
  • Fix the failures
  • Set the GitLab job to hard fail
  • Create a merge request
  • Review
  • Merge

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork fragments-3447534

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

eelkeblok created an issue. See original summary.

Diwakar07 made their first commit to this issue’s fork.

diwakar07’s picture

diwakar07 commented
Assigned: Unassigned » diwakar07

Diwakar07 opened merge request !19

eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Issue summary: View changes
eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Status: Active » Needs work

Wow, that was quick. I think we should also make sure GitLab breaks once we've made sure we have a baseline.

diwakar07’s picture

diwakar07 commented
Assigned: diwakar07 » Unassigned
Status: Needs work » Needs review

Hi @eelkeblok,
Created an MR for cspell issues. cspell check is passing now.
Can you please elaborate what needs to be done next here ?

kalash-j’s picture

kalash-j commented
Status: Needs review » Reviewed & tested by the community

Pipeline is working fine and there is no cspell errors
RTBC+1 to merge MR!19

eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Status: Reviewed & tested by the community » Needs work

@Diwakar07 The ESlit check makes the build fail when it does not pass. See https://git.drupalcode.org/project/fragments/-/blob/2.x/.gitlab-ci.yml?r...

diwakar07’s picture

diwakar07 commented
Status: Needs work » Needs review

Hi @eelkeblok,

Configured the cspell job to break when it does not pass.
Please review.

sourav_paul’s picture

sourav_paul
Location Kolkata
commented

@eelkeblok cspell job isn't failing anymore: https://git.drupalcode.org/issue/fragments-3447534/-/pipelines/244180

sourav_paul’s picture

sourav_paul
Location Kolkata
commented
Status: Needs review » Reviewed & tested by the community
eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Status: Reviewed & tested by the community » Fixed

Thanks. The latest commit fails its tests, but that is not due to these changes.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Status: Closed (fixed) » Needs review

eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Status: Needs review » Fixed

Forgot to actually merge.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.