Problem/Motivation

Currently the module only supports Tableau visualizations hosted on https://public.tableau.com.

Proposed resolution

  • A settings form to configure additional hosts.
  • An event subscriber to add additional hosts to the frame-src directive if the Content Security Policy module is enabled.
  • Changes to the MediaTableauField formatter to support the additional hosts

Issue fork media_tableau-3447283

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

minirobot created an issue. See original summary.

minirobot changed the visibility of the branch 3447283-add-support-for to hidden.

minirobot opened merge request !3

minirobot’s picture

minirobot commented
Status: Active » Needs review
minirobot’s picture

minirobot commented

Review/Testing instructions for the merge request:

1. Configure allowed hosts at /admin/config/media/tableau.
2. Create a Tableau media item with the embed hosted at one of the allowed hosts entered above.
3. Test with both self and publicly (https://public.tableau.com) hosted domains.

javi-er’s picture

javi-er commented

I left two small comments in the PR, but I tested it locally and it's working great! existing visualizations pointing to the public domain keeps working, and if I add another domain, it works well too.

penyaskito made their first commit to this issue’s fork.

javi-er’s picture

javi-er commented
Status: Needs review » Fixed

I tested this MR in my local and it's working as expected, thanks!!

javi-er’s picture

javi-er commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.