Problem/Motivation
If you happen to have a file ending in component.yml in a directory named components, SDC will assume it is their component.
It's supposed to only find files ending in .component.yml (with that extra dot)
Steps to reproduce
Create a components directory and add a YAML file ending in components.yml but not .components.yml
Proposed resolution
Fix the regex
Remaining tasks
N/A
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Release notes snippet
N/A
Issue fork drupal-3446381
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3446381-sdc-discovery-regex-fail
changes, plain diff MR !8009
- 3446381-test-only
changes, plain diff MR !8123
Comments
Comment #4
tim.plunkettComment #5
tim.plunkettfrom @longwave in Slack:
Comment #9
smustgrave commentedSorry for the noise with the extra PR but the test-only feature wouldn't fail so made a separate MR which shows the failure.
https://git.drupalcode.org/issue/drupal-3446381/-/jobs/1628220
Update to regex appears to work.
Comment #14
catchCommitted/pushed to 11.x and cherry-picked to 11.0.x, 10.4.x, 10.3.x, thanks!