Problem/Motivation

If you happen to have a file ending in component.yml in a directory named components, SDC will assume it is their component.
It's supposed to only find files ending in .component.yml (with that extra dot)

Steps to reproduce

Create a components directory and add a YAML file ending in components.yml but not .components.yml

Proposed resolution

Fix the regex

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3446381

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett’s picture

Issue tags: +Portland2024
tim.plunkett’s picture

Version: 11.0.x-dev » 11.x-dev
Status: Active » Needs review

from @longwave in Slack:

MRs against 11.x are ok and will be preferred once 11.0.0-beta1 is out and 11.1-only changes go into 11.x (yes this is confusing, can't wait until we can use main)

smustgrave made their first commit to this issue’s fork.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Sorry for the noise with the extra PR but the test-only feature wouldn't fail so made a separate MR which shows the failure.

https://git.drupalcode.org/issue/drupal-3446381/-/jobs/1628220

Update to regex appears to work.

  • catch committed f61ef1e5 on 11.0.x
    Issue #3446381 by tim.plunkett, smustgrave, sarahjean: SDC's discovery...

  • catch committed f1b4d8cc on 11.x
    Issue #3446381 by tim.plunkett, smustgrave, sarahjean: SDC's discovery...

  • catch committed 9d954ccd on 10.3.x
    Issue #3446381 by tim.plunkett, smustgrave, sarahjean: SDC's discovery...

  • catch committed 46471530 on 10.4.x
    Issue #3446381 by tim.plunkett, smustgrave, sarahjean: SDC's discovery...
catch’s picture

Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.0.x, 10.4.x, 10.3.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.