Problem/Motivation

Social media render issue when enable "Show About Block" from theme setting getting twitter icon display twice.

Steps to reproduce

1 Install the theme and set as default.
2 Go to the theme settings.
3) checked "Show About Block" option
4 Go to home page .
you will find the twitter icon comes twice.

issue

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#10 Before.png69.82 KBriddhi.addweb
#10 After.png78.88 KBriddhi.addweb
#9 ajans-twitter-after.png26.23 KBbindu r
#9 ajans-twitter-before.png28.81 KBbindu r
#6 conf.png10.67 KBtanuja bohra
#6 after_patch.png25.97 KBtanuja bohra
insta_twice.PNG37.98 KBgautam_105@

Issue fork ajans-3444817

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Gautam_105@ created an issue. See original summary.

gautam_105@’s picture

gautam_105@ commented
Issue summary: View changes

adarshv made their first commit to this issue’s fork.

adarshv opened merge request !36

adarshv’s picture

adarshv commented
Status: Active » Needs review

Fixed. Please check MR !36 above.

tanuja bohra’s picture

tanuja bohra commented
StatusFileSize
new after_patch.png25.97 KB
new conf.png10.67 KB

@adarshv, the duplicate Twitter icon issue is resolved. But I can see another issue here if the user didn't put any YouTube URL still that icon is showing and there is no field for WhatsApp but still it's showing.

tanuja bohra’s picture

tanuja bohra commented
Status: Needs review » Needs work
adarshv’s picture

adarshv commented
Status: Needs work » Needs review
bindu r’s picture

bindu r commented
StatusFileSize
new ajans-twitter-before.png28.81 KB
new ajans-twitter-after.png26.23 KB

Hi, Reviewed the MR 36 , fixes the duplicate twitter icon issue and also fixes the issues mentioned #6.

riddhi.addweb’s picture

riddhi.addweb commented
StatusFileSize
new After.png78.88 KB
new Before.png69.82 KB

The mentioned Social icon render issue is resolved. I have also checked and it is working as expected. Attaching the Screenshots & doing RTBC for the same.

riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Reviewed & tested by the community