Follow up to: https://www.drupal.org/project/drupal/issues/2952488

Problem/Motivation

The "current page" element in the pager is announced twice to users.

Steps to reproduce

Navigate to the current page element in a pager using NVDA or another screen reader active.

Proposed resolution

From the previous issue:
Remove the visually-hidden phrase "current page" from inside the current-page link. Just usePage: like all the other numbered links.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
Screenshot from 2024-04-30 13-41-46.png9.29 KBneclimdul

Issue fork drupal-3444512

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

neclimdul created an issue. See original summary.

neclimdul opened merge request !7856

neclimdul’s picture

neclimdul
He/Him
commented
Status: Active » Needs review

These changes where just accidentally dropped from a re-roll. Patch to re-introduce them.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Have a test failure so maybe fixing that will count as test coverage.

But will need a change record for contrib themes to update their templates.

neclimdul’s picture

neclimdul
He/Him
commented
Status: Needs work » Needs review

Test should be fixed.

smustgrave’s picture

smustgrave commented

Can we get a change record also please.

neclimdul’s picture

neclimdul
He/Him
commented

created

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Thanks! As mentioned I feel the test change counts as coverage.

Change looks good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

#3384679: aria-current is giving an invalid value reverted the changes from #2952488: Use aria-current=page in pagination links. so this issue might no longer true.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Reviewed & tested by the community

Oh I see - it just got the value wrong. This is still good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Re change record - it wasn't this change that necessitated the contrib / custom themes to change it was #2952488: Use aria-current=page in pagination links.

Committed 3a54db4 and pushed to 11.x. Thanks!
Committed 93d5421 and pushed to 10.4.x. Thanks!
Committed 45cb9fe and pushed to 10.3.x. Thanks!

  • alexpott committed 45cb9fed on 10.3.x 
    Issue #3444512 by neclimdul, alexpott, smustgrave: Pager current page...

  • alexpott committed 93d54212 on 10.4.x 
    Issue #3444512 by neclimdul, alexpott, smustgrave: Pager current page...

  • alexpott committed 3a54db4a on 11.x 
    Issue #3444512 by neclimdul, alexpott, smustgrave: Pager current page...

  • alexpott committed 3a54db4a on 11.0.x 
    Issue #3444512 by neclimdul, alexpott, smustgrave: Pager current page...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.