Problem/Motivation

While fixing #3439907: Fix System tests that rely on UID1's super user behavior it's found that the test case testLocalTaskBlockCache asserting no local tasks results in false positive if the correct permissions were not given. Test passes even if the permission 'administer account settings' is removed.

Steps to reproduce

Proposed resolution

Add an assert to check if the page /admin/config/people/accounts was actually rendered before asserting for no local tasks.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3443748

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sukr_s created an issue. See original summary.

smustgrave’s picture

smustgrave commented
Issue tags: +Novice

Thanks for opening, tagging for new users as should be a good intro for them.

NexusNovaz made their first commit to this issue’s fork.

nexusnovaz’s picture

nexusnovaz commented
Assigned: Unassigned » nexusnovaz

NexusNovaz opened merge request !7947

nexusnovaz’s picture

nexusnovaz commented
Assigned: nexusnovaz » Unassigned
Status: Active » Needs review

This is ready for review. I have added the code which i believe to be correct, though, im unable to test locally (unsure how, even after googling, using ddev)

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Believe the permissions have to be slightly updated as the test is failing

https://git.drupalcode.org/issue/drupal-3443748/-/jobs/1536596

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Portland2024

This does seem like a good issue for novice contributors to investigate (with regard to why the test is currently failing). One helpful step would also be to manually test a site with the test's setup and validate that it is actually working correctly.

Additionally, I left a note on the MR to remove the old inline comment.

Novice issue reserved for the Mentored Contribution during the Contribution Day at DrupalCon Portland 2024. After the 8th of May 2024, this issue returns to being open to all. Thanks!
nexusnovaz’s picture

nexusnovaz commented
Status: Needs work » Needs review

Hi, i believe this is now good for review. Added the permission to allow it to pass the test and now we're all green.

Apologies for the commit spam, im unsure how to test locally and am still fairly new to Drupal.

Hopefully this solution is fine!

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

No need to apologize! Good job figuring out the permission. Do believe this one is good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 565a9f1401 to 11.x and 4874e83fb3 to 11.0.x and 9181970ca4 to 10.4.x and 0f4d8306b1 to 10.3.x. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

  • alexpott committed 0f4d8306 on 10.3.x 
    Issue #3443748 by NexusNovaz, smustgrave: Testcase creates false...

  • alexpott committed 9181970c on 10.4.x 
    Issue #3443748 by NexusNovaz, smustgrave: Testcase creates false...

  • alexpott committed 4874e83f on 11.0.x 
    Issue #3443748 by NexusNovaz, smustgrave: Testcase creates false...

  • alexpott committed 565a9f14 on 11.x 
    Issue #3443748 by NexusNovaz, smustgrave: Testcase creates false...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.