Problem/Motivation
PHPUnit 10 deprecates use of non-static @dataProvider methods.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3443533
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3443533-change-dataprovider-to
changes, plain diff MR !7760
Comments
Comment #2
mondrakeComment #4
longwaveFor this one we can store the entity IDs and generate the mocks in the test method where required. Also took the liberty to convert the array format to a generator to make the data provider easier to read.
Comment #5
mondrakeCan we fully typehint both the providers and the test methods then, we did so in other similar situations
Comment #6
longwaveAdded types everywhere.
Comment #7
mondrakeComment #8
longwaveThanks, addressed, also cleaned up the rest of the method a bit.
Comment #9
mondrakeLooks all good, thanks.
Comment #10
pravesh_poonia commentedApplied MR, changes looking fixed now
Comment #13
catchCommitted/pushed to 11.x and cherry-picked to 10.3.x, thanks!