Problem/Motivation

When upgrading a site from CKEditor 4 to CKEditor 5, it may be necessary to have both modules installed and enabled at once.

The ckeditor_iframe_requirements() code only checks that CKEditor 4 is installed, and will not let you proceed with installation if the iFrame library is missing.

If you plan to use the module only with CKEditor 5, it is not possible to install without first installing a redundant CKEditor 4 iFrame plugin.

Steps to reproduce

1. Install a new Drupal 10 install
2. Install CKEditor 4 and CKEditor 5 modules.
3. Try to install this module without first installing the CKEditor 4 library.

Proposed resolution

Change REQUIREMENT_ERROR to REQUIREMENT_WARNING in ckeditor_iframe.install.

Issue fork ckeditor_iframe-3443099

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mattjones86 created an issue. See original summary.

mattjones86’s picture

mattjones86
Location 🇬🇧 GMT+0
commented
Issue summary: View changes

mattjones86 opened merge request !6

mattjones86’s picture

mattjones86
Location 🇬🇧 GMT+0
commented
Status: Needs work » Needs review
bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Status: Needs review » Postponed (maintainer needs more info)

Hmm... are you sure? That whole code block is wrapped in an if statement that only executes when the "ckeditor" module is installed (CKEditor 4). So if you don't have CKE4 installed, then it shouldn't block anything when attempting to install this module.

firfin’s picture

firfin commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)

I did not have this problem when installing without CKE4.
Also no activity from OP, so I think this can go on the closed pile :-)

mattjones86’s picture

mattjones86
Location 🇬🇧 GMT+0
commented

Sorry I've not been on Drupal in a while but if I recall, the problem mainly happens when trying to perform a migration from CKEditor 4 to CKEditor 5, in which case you may have both modules installed at the same time.

If you only want to use this plugin on CKEditor 5 you cannot, because installation is blocked unless you also install the separate CKEditor 4 library.

mattjones86’s picture

mattjones86
Location 🇬🇧 GMT+0
commented
Issue summary: View changes
mattjones86’s picture

mattjones86
Location 🇬🇧 GMT+0
commented
Status: Closed (cannot reproduce) » Needs review

I have provided more detail, sorry my original explanation was not the best!

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented

Thank you! Committed.

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.