Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3442713

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch opened merge request !7657

Binoli Lalani made their first commit to this issue’s fork.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs work

Still a couple of unit test failures.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Also lots more:

core/lib/Drupal/Core/Entity/EntityTypeRepository.php:      @trigger_error('Calling EntityTypeRepository::__construct() without the $entityTypeBundleInfo argument is deprecated in drupal:10.3.0 and is required in drupal:11.0.0. See https://www.drupal.org/node/3365164', E_USER_DEPRECATED);
core/lib/Drupal/Core/Entity/KeyValueStore/KeyValueEntityStorage.php:    @trigger_error(__METHOD__ . '() is deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. Use \Drupal\Core\Entity\RevisionableStorageInterface::loadRevision instead. See https://www.drupal.org/node/3294237', E_USER_DEPRECATED);
core/lib/Drupal/Core/Entity/KeyValueStore/KeyValueEntityStorage.php:    @trigger_error(__METHOD__ . '() is deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. Use \Drupal\Core\Entity\RevisionableStorageInterface::deleteRevision instead. See https://www.drupal.org/node/3294237', E_USER_DEPRECATED);
core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php:            @trigger_error('Not providing a setDefaultTranslationEnforced() method when implementing \Drupal\Core\TypedData\TranslatableInterface is deprecated in drupal:10.2.0 and is required from drupal:11.0.0. See https://www.drupal.org/node/3376146', E_USER_DEPRECATED);
core/lib/Drupal/Core/Entity/Controller/EntityController.php:      @trigger_error('Calling ' . __METHOD__ . '() without the $route_match argument is deprecated in drupal:10.1.0 and it will be required in drupal:11.0.0. See https://www.drupal.org/node/3337782', E_USER_DEPRECATED);

smustgrave made their first commit to this issue’s fork.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Tried to address additional ones but could use some feedback about the KeyValueStorage

catch’s picture

catch
he/him
Primary language English
commented

The KeyValue changes look sensible - removing methods from the non-revisionable storage and adding them to the ones that are.

arun.k’s picture

arun.k commented

@ binoli-lalani @longwave kindly please provide which tool you are using to check the deprecated code. so i can review this code. Because drupal-check is not working in drupal 11 setup

catch’s picture

catch
he/him
Primary language English
commented

@Arun.k there is no special tooling, we are just grepping the relevant directories, like:

grep -r @deprecated core/lib/Drupal/Core/Entity/

Code that should be 'removed from drupal:11.0.0' is in scope for these issues. Code that says 'removed from drupal:12.0.0' should be left where it is for now.

arun.k’s picture

arun.k commented

Thankyou @catch for the knowledge and @smustgrave I have Verified and tested Merge request !7657 3442713-remove-deprecated-code on Drupal Version 11.x-dev & PHP Version 8.3

Testing Steps:-
1). Install Drupal 11.x version.
2). /projects/drupal/ git remote add drupal-3442713 https://git.drupalcode.org/issue/drupal-3442713.git
3). git fetch drupal-3442713
4). git checkout -b '3442713-remove-deprecated-code' --track drupal-3442713/'3442713-remove-deprecated-code'
5). use vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml core/lib/Drupal/Core/Entity/KeyValueStore/KeyValueContentEntityStorage.php
6). use vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml core/.phpstan-baseline.php to check deprecated code removed or not

Testing result:
Merge request !7657 3442713-remove-deprecated-code is fixed
Moved the issue to RTBC ++

arun.k’s picture

arun.k commented
Status: Needs review » Reviewed & tested by the community
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Needs work

Missed one earlier, I think core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php is in scope given it's the same revision methods we are deleting elsewhere in this issue.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review

Fixed #13, also re-added the comments back to EntityRepositoryInterface as that relates to code that is staying until Drupal 12.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Additional change seems good. Going to mark since this is blocking another deprecation ticket.

  • catch committed 280a46c0 on 11.x 
    Issue #3442713 by smustgrave, catch, Binoli Lalani, longwave: Remove...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Got this started but missed so many here I think I'm still OK to commit. Committed/pushed to 11.x, thanks!

catch closed merge request !7657

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.