Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3442532

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Component: taxonomy.module » views.module
Status: Needs review » Active

smustgrave made their first commit to this issue’s fork.

smustgrave opened merge request !7656

smustgrave’s picture

smustgrave commented
Status: Active » Needs review
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Needs work

Couple of comments on the MR.

pradhumanjain2311 made their first commit to this issue’s fork.

andypost made their first commit to this issue’s fork.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review

Clean-up what was able to find, added views_ui

btw there's views.view.*.mapping.display.sequence.mapping.cache_metadata.mapping.cacheable which has comment as it was deprecated but all views has this property, I bet it needs follow-up somehow

smustgrave’s picture

smustgrave commented

I tried removing that before and got schema errors everywhere.

smustgrave’s picture

smustgrave commented

@andypost can you take a look at the phpcs.

andypost’s picture

andypost
he/him
Primary language Russian
commented

Thank you! fixed CS, re #10 - that's why it needs follow-up

catch’s picture

catch
he/him
Primary language English
commented

#9/10 what's happened is that issues have been committed that update the views schema, with an update path, but which don't fix the shipped views to be compliant. Then when we remove bc layers like there, everything blows up. This is a problem with the original MRs that went in, but in most cases that was months/years ago.

The ideal thing is to either manually fix or re-export those views so that they have the correct schema, but we could also open a separate issue for anything tricky here and just commit the changes that don't require updating test fixtures.

I ran into similar problems on #3442162: Remove redundant hook_ENTITY_TYPE_presave() and ViewsConfigUpdater methods

smustgrave’s picture

smustgrave commented

Opened #3442960: Update core views with correct config

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Kernel test was random failure.

  • catch committed 7553ab8c on 11.x 
    Issue #3442532 by smustgrave, andypost, pradhumanjain2311, quietone:...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

smustgrave closed merge request !7656

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.