menu.default_tree_manipulators:generateIndexAndSort sorting is not always alphabetical

Problem/Motivation

The default menu tree manipulator generateIndexAndSort should sort menu items by weight and then by title (alphabetically). However if two menu items have the same weight and a title starting with the same text, the item with the longer title typically is (incorrectly) sorted before the item with the shorter title.

The manipulator uses ksort to sort the menu items. The keys consist of a fixed prefix, the weight, name and plugin id of the menu item. The addition of the plugin id is required to ensure the keys are unique, however results in this incorrect sorting.

Steps to reproduce

Add two or more menu links to a menu with the same weight:

• Menu link A
• Menu link A (extra text)

Verify that the menu links are incorrectly sorted:

• Menu link A (extra text)
• Menu link A

Proposed resolution

Instead of using ksort() on a generated/composed key, simply use uasort().