Problem/Motivation

This is a follow-up issue of #3441795: Adjust the logging for the local endpoint implementation.
Sometimes we do not want any noise coming from this module.

Steps to reproduce

Proposed resolution

Create an option to turn off any logging coming from this module.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork friendlycaptcha-3441994

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grevil created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

As written in #10 in the other issue, please implement this as "Debug" opt-in. I guess there are some other modules doing it the same way.

This should only affect the notices which the admin can't do anything about.

Grevil opened merge request !27

grevil’s picture

grevil commented
Status: Active » Needs work

We talked about this internally. Apparently it is wiser to invert this feature.

grevil’s picture

grevil commented
Status: Needs work » Needs review

Done, please review.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil
Status: Needs review » Needs work

Well done, just two minimal improvements to make this more useful and understandable for the outside world :)

RTBC afterwards!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: Create an option to turn off any logging from this module » Create an option to turn off the local endpoint notice logging
grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Needs work » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Perfect! :)

  • Anybody committed 4269c280 on 1.x authored by Grevil 
    Issue #3441994 by Grevil, Anybody: Create an option to turn off the...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.