Problem/Motivation

Remove deprecated code in utilities

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3441394

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !7535

quietone’s picture

quietone commented
Issue tags: -Deprecation Removal Major version only +Deprecation Removal, +Major version only
quietone’s picture

quietone commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Searching for deprecated and 11.0 found a missing instance in
Token.php

Also a comment in LinkGenerator // @todo System path is deprecated - use the route name and parameters.

pradhumanjain2311 made their first commit to this issue’s fork.

quietone’s picture

quietone commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented

Quick glance but link generator is removing a comment. Does the code need to be tweaked at all?

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Believe the comment in linkGenerator was left over.

https://git.drupalcode.org/project/drupal/-/commit/bf4a582850e66bc28cfd0... was the commit it was added.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs followup

That @todo wasn't a leftover, it's not been worked on since it was added. I think we can remove the @todo, but let's open an issue for what it was trying to do so the thought is still tracked - left a comment on the MR and marking needs work for the follow-up to be opened.

smustgrave’s picture

smustgrave commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs followup

Opened up follow ups for both threads

Added comment back and since that was the only change I did think good to self RTBC.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

I think we should probably add the type hints that were moved to a follow-up in this issue - gave reasons in the MR.

smustgrave’s picture

smustgrave commented
Status: Needs work » Reviewed & tested by the community

added typehints.

  • catch committed d04db767 on 11.x 
    Issue #3441394 by quietone, smustgrave, pradhumanjain2311, catch: Remove...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

catch closed merge request !7535

  • catch committed d04db767 on 11.0.x 
    Issue #3441394 by quietone, smustgrave, pradhumanjain2311, catch: Remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.