Drupal 10.2
cloudflare-2.0.0-alpha1
The zoneId is not always an array. Patch attached.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 3441101-9.patch | 620 bytes | michaellenahan |
| #3 | 3441101-3.patch | 910 bytes | michaellenahan |
Drupal 10.2
cloudflare-2.0.0-alpha1
The zoneId is not always an array. Patch attached.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 3441101-9.patch | 620 bytes | michaellenahan |
| #3 | 3441101-3.patch | 910 bytes | michaellenahan |
Comments
Comment #2
michaellenahan commentedComment #3
michaellenahan commentedHere is the patch.
Comment #4
mxh commentedAccording to schema definition of cloudflare module, it should be an array both in 8.x-1.x as well as 2.0.x: https://git.drupalcode.org/project/cloudflare/-/blob/2.0.x/config/schema...
Comment #5
michaellenahan commentedHi mxh and thanks!
Okay - I’m not sure why I’m getting a string value here, need to investigate further at my end.
Meantime feel free to close as wontfix, the issue will still be here in case anyone else gets the same error, then they can comment and reopen.
Comment #7
mxh commentedCommitted your patch, so that both cases are supported.
Comment #8
mxh commentedComment #9
michaellenahan commentedRe-opening this issue, because there is a syntax error in the patch.
Instead of this:
if is_array($instance->zoneId) {... we should have this ...
if (is_array($instance->zoneId)) {Here is the updated patch to be applied on top of 1.0.x-dev
Comment #10
michaellenahan commentedBy the way @mxh I would be happy to become a maintainer if that helps you. I don't think many people are actively using this module, but we are (still).
Comment #12
mxh commented@michaellenahan Sure, I've added you as maintainer to this project.