Drupal 10.2
cloudflare-2.0.0-alpha1

The zoneId is not always an array. Patch attached.

CommentFileSizeAuthor
#9 3441101-9.patch620 bytesmichaellenahan
#3 3441101-3.patch910 bytesmichaellenahan

Comments

michaellenahan created an issue. See original summary.

michaellenahan’s picture

Issue summary: View changes
michaellenahan’s picture

StatusFileSize
new910 bytes

Here is the patch.

mxh’s picture

According to schema definition of cloudflare module, it should be an array both in 8.x-1.x as well as 2.0.x: https://git.drupalcode.org/project/cloudflare/-/blob/2.0.x/config/schema...

michaellenahan’s picture

Hi mxh and thanks!

Okay - I’m not sure why I’m getting a string value here, need to investigate further at my end.

Meantime feel free to close as wontfix, the issue will still be here in case anyone else gets the same error, then they can comment and reopen.

  • mxh committed 76af4a53 on 1.0.x
    Issue #3441101 by michaellenahan: TypeError: reset(): Argument #1 ()...
mxh’s picture

Version: 1.0.0-rc4 » 1.0.x-dev
Status: Active » Fixed

Committed your patch, so that both cases are supported.

mxh’s picture

michaellenahan’s picture

Status: Fixed » Needs review
StatusFileSize
new620 bytes

Re-opening this issue, because there is a syntax error in the patch.

Instead of this:

if is_array($instance->zoneId) {

... we should have this ...

if (is_array($instance->zoneId)) {

Here is the updated patch to be applied on top of 1.0.x-dev

michaellenahan’s picture

By the way @mxh I would be happy to become a maintainer if that helps you. I don't think many people are actively using this module, but we are (still).

  • mxh committed ecd5aa0c on 1.0.x
    Issue #3441101 by michaellenahan: TypeError: reset(): Argument #1 ()...
mxh’s picture

Status: Needs review » Fixed

@michaellenahan Sure, I've added you as maintainer to this project.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.