All the code that was deprecated in version 4 should be removed in version 5.
See @deprecated.

Issue fork shorthand-3440969

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

VladimirAus created an issue. See original summary.

Mohd Sahzad made their first commit to this issue’s fork.

thakurnishant_06 made their first commit to this issue’s fork.

thakurnishant_06 opened merge request !25

DECHEN DORJI’s picture

DECHEN DORJI commented

Need Proper Steps to reproduce and screenshots

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Active » Needs work

@DECHEN DORJI: steps - remove code marked as deprecated. Example: https://git.drupalcode.org/project/shorthand/-/blob/4.0.x/src/Entity/Sho...

@thakurnishant_06: thanks for the commit. There is merge error.

vladimiraus changed the visibility of the branch 3440969-remove-deprecated-code to hidden.

hetal.solanki’s picture

hetal.solanki
Primary language English
commented
Assigned: Unassigned » hetal.solanki

hetal.solanki changed the visibility of the branch 3440969-Fix-deprecated-code to hidden.

hetal.solanki changed the visibility of the branch 3440969-Fix-deprecated-code to active.

hetal.solanki’s picture

hetal.solanki
Primary language English
commented

@vladimiraus

I have remove @deprecated line . Could you please check it once?

Let me know if there any changes?

Thank you!!

hetal.solanki’s picture

hetal.solanki
Primary language English
commented
Assigned: hetal.solanki » Unassigned
Status: Needs work » Needs review

hetal.solanki changed the visibility of the branch 3440969-Fix-deprecated-code to hidden.

hetal.solanki changed the visibility of the branch 3440969-Fix-deprecated-code to active.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Priority: Minor » Normal
Status: Needs review » Needs work
  • It's deprecated code that needs to be removed, not deprecated comments.
  • Linting issues should be addressed separately. Please remove.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Needs work » Needs review

Pushed to 5.0.x
needs review and testing.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Needs review » Fixed

5.0.x is ready for testing.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented

  • vladimiraus committed c3318c0f on 5.0.x 
    Issue #3440969 by hetal.solanki, vladimiraus: Remove deprecated code

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.