Problem/Motivation

Before tagging beta1 we should ensure the code is clean and phpcs and phpcbf are happy. :)

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork billwerk_subscriptions-3439604

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Anybody created an issue. See original summary.

  • Anybody committed cfc5fb1a on 1.x 
    Issue #3439604 by Anybody: Final code style cleanup - phpcbf
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Made a first phpcbf run at 1.x

Grevil made their first commit to this issue’s fork.

grevil’s picture

grevil commented

Jesus Christ, 700 phpcs issues? What happened here?

grevil’s picture

grevil commented

Grevil opened merge request !23

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Active » Needs review

Alright, all done.

Eslint, stylelint and cspell are still open, but I fixed phpstan and phpcs issues.

grevil’s picture

grevil commented
Title: Final code style cleanup » Add tests and final code style cleanup
Assigned: Unassigned » grevil
Status: Needs review » Needs work

Everything green now!

As discussed internally with @Anybody, we will also implement the tests inside this issue here. :)

grevil’s picture

grevil commented

A lot of schema errors.

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Needs work » Needs review

Ok, this requires too many changes that need to be properly reviewed.

Let's resolve the schema errors in a follow-up issue. Please review!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Whao. LGTM, just see the comments please.

Any risky changes?

grevil’s picture

grevil commented
Assigned: Unassigned » anybody
Status: Reviewed & tested by the community » Needs review

Alright, I just took a look at all the changes and made a few tiny adjustments. Also added a comment. Please resolve the comment @Anybody and give your final review!

grevil’s picture

grevil commented
Status: Needs review » Reviewed & tested by the community

Follow-up issue #1: #3442075: Fix schema and other test issues

Follow-up issue #2: #3442080: "$this->getAuthToken()" seems to not be used through $headers

  • Grevil committed a19647b3 on 1.x 
    Issue #3439604 by Grevil, Anybody: Final code style cleanup
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Merging.

grevil’s picture

grevil commented
Assigned: anybody » Unassigned
grevil’s picture

grevil commented

Ignore last commit, it wasn't committed to 1.x anyway.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.