Problem/Motivation

When an installation is using a language diferent from English and a topic is created related with a course group, on the page to edit this topic the group field isn't loading options and it is loaded empty. When this field is empty and the user save it, the field wil be cleanned.

This happen because a hook-form-alter is removing some options using translation string on if and it never match when the installation is using languages different from English

Steps to reproduce

- Install Social Course
- Change default language
- Create a course group
- Create a topic and related with couse before
- Edit the topic and check group field

Proposed resolution

Change the check to use only English string to avoid problems with installation if others language.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#7 social-course-group-field-empty-on-topic-edit-page-3438928-7.patch1.93 KBviniciusrp
#6 social-course-group-field-empty-on-topic-edit-page-3438928-6.patch5.48 KBviniciusrp
#5 social-course-group-field-empty-on-topic-edit-page-3438928-5.patch1.54 KBviniciusrp
#2 social-course-group-field-empty-on-topic-edit-page-3438928-2.patch624 bytesviniciusrp

Issue fork social_course-3438928

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

viniciusrp created an issue. See original summary.

viniciusrp’s picture

viniciusrp commented
StatusFileSize
new social-course-group-field-empty-on-topic-edit-page-3438928-2.patch624 bytes

I removed the translation function on check and use string in English hardcoded.

viniciusrp opened merge request !61

viniciusrp’s picture

viniciusrp commented
Status: Active » Needs review
viniciusrp’s picture

viniciusrp commented
StatusFileSize
new social-course-group-field-empty-on-topic-edit-page-3438928-5.patch1.54 KB

A new solution with a better approach.

viniciusrp’s picture

viniciusrp commented
StatusFileSize
new social-course-group-field-empty-on-topic-edit-page-3438928-6.patch5.48 KB

New patch fixing small errors

viniciusrp’s picture

viniciusrp commented
StatusFileSize
new social-course-group-field-empty-on-topic-edit-page-3438928-7.patch1.93 KB

New patch with a fix for multiple array

robertragas’s picture

robertragas commented

Will be landing in 5.1.5 and 5.2.2

robertragas’s picture

robertragas commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.