Problem/Motivation

An error occurred when requesting "xero_contact" from an invalid declaration of the "BrandingTheme" field.

Steps to reproduce

\Drupal::service('xero.query')->setType('xero_contact')->addCondition('Name', $client_name)->execute();

The $client_name must have "BrandingTheme" assigned

Proposed resolution

Patch Proposed

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 Missing_BrandingTheme_when_requesting_Contact_3437835.patch1.13 KBusandul

Issue fork xero-3437835

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

USandul created an issue. See original summary.

usandul’s picture

usandul commented
StatusFileSize
new Missing_BrandingTheme_when_requesting_Contact_3437835.patch1.13 KB

mradcliffe made their first commit to this issue’s fork.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Version: 3.0.0-alpha2 » 3.0.x-dev

I reviewed the API, and the patch makes sense.

drupal.org uses GitLab CI now and xero api module has been converted to its use. That means patch files won't be run through tests. I created an issue fork.

Can you commit your patch to the issue fork branch?

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Active » Needs work

mradcliffe opened merge request !12

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs work » Needs review
mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs review » Needs work

Changes to Needs work because of failed test.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs work » Needs review

I resolved the test failures in the merge request. I'll let this sit for a week or so.

  • mradcliffe committed 8c6b673c on 3.0.x 
    Issue #3437835 by mradcliffe, USandul: An error occurred when requesting...
mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.