Problem/Motivation

The phpcs and phpstan warnings is a big noise to signal ratio, and I should reduce the amount of noise. There are some improvements coming in mglaman/drupal-phpstan for the next version of Drupal (drupal/core/dev) that should also help infer types.

Proposed resolution

Address the most common warnings.

Issue fork xero-3436973

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mradcliffe created an issue. See original summary.

mradcliffe opened merge request !11

  • mradcliffe committed 861e02ed on 3.0.x 
    Issue #3436973 by mradcliffe: Code cleanup for 3.0.x
mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Active » Fixed

Did some smoke testing and was able to go through invoices, contacts, accounts.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.