Problem/Motivation

Follow up from #2002012: Inject the display plugin manager into the view and view factory from @catch

I think we could open a follow-up to use the DependencySerializationTrait in ViewsExecutabl... it'll be a little complex because we'll need to do a little work to make things work...
Also I think we should open a follow-up to use $this->provider in \Drupal\views\ViewExecutable::hasUrl() instead of \Drupal::service().

Second one will be covered here

Steps to reproduce

NA

Proposed resolution

Use provider in ViewExecutable::hasUrl() instead of \Drupal::service()

Remaining tasks

TBD

User interface changes

NA

API changes

TBD

Data model changes

TBD

Release notes snippet

TBD

Issue fork drupal-3436814

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

samit.310@gmail.com made their first commit to this issue’s fork.

fromme made their first commit to this issue’s fork.

fromme opened merge request !7387

fromme’s picture

fromme commented
Status: Active » Needs review

Replaced Drupal::service() with $this->routeProvider in ViewExecutable::hasUrl().
Opened MR.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems pretty straight forward.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed c9879d2d55 to 11.x and 485cf20777 to 10.3.x. Thanks!

  • alexpott committed 485cf207 on 10.3.x 
    Issue #3436814 by fromme, smustgrave: Use provider in ViewExecutable::...

  • alexpott committed c9879d2d on 11.x 
    Issue #3436814 by fromme, smustgrave: Use provider in ViewExecutable::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.