Problem/Motivation

  • Drupal has changed to using modal's when accessing Delete links based on this issue: https://www.drupal.org/project/drupal/issues/2253257
  • Add CSS for modal windows and adjust the Delete buttons. We need to support the Delete button because when a modal window is accessed, the original Delete button is hidden, and the Dialog JS writes another one on the lower right hand side.
  • See screenshot:
CommentFileSizeAuthor
#3 Edit_arm_ubuntu___Cloud_Orchestrator.png238.01 KBbaldwinlouie
AWS_Cloud_security_groups___Cloud_Orchestrator.png119.7 KBbaldwinlouie

Issue fork rigel-3436310

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

baldwinlouie created an issue. See original summary.

baldwinlouie opened merge request !58

baldwinlouie’s picture

baldwinlouie commented
Status: Active » Needs review
StatusFileSize
new Edit_arm_ubuntu___Cloud_Orchestrator.png238.01 KB

@yas, please review this patch. It adds css styling to modals.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: support modal delete windows » Support modal delete windows
Category: Task » Support request
Issue summary: View changes

@baldwinlouie

Thank you for the fix. I'll merge the patch to 6.x and 7.x; and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Support modal delete windows » Support modal delete dialog windows

  • yas committed bb0fc12b on 7.x authored by baldwinlouie 
    Issue #3436310 by baldwinlouie, yas: Support modal delete dialog windows

  • yas committed 3da5b839 on 6.x authored by baldwinlouie 
    Issue #3436310 by baldwinlouie, yas: Support modal delete dialog windows

baldwinlouie opened merge request !59

baldwinlouie’s picture

baldwinlouie commented
Status: Reviewed & tested by the community » Needs review

@yas, please review the hotfix. This fixes the coder issue.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

Thank you for the hotfix. I'll merge the patch to 6.x and 7.x; and close this issue as Fixed.

  • yas committed cd65de8b on 7.x authored by baldwinlouie 
    Issue #3436310 by baldwinlouie, yas: Hotfix - Support modal delete...

  • yas committed 172f236e on 6.x authored by baldwinlouie 
    Issue #3436310 by baldwinlouie, yas: Hotfix - Support modal delete...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

baldwinlouie opened merge request !60

baldwinlouie’s picture

baldwinlouie commented
Status: Fixed » Needs review

@yas, I opened a hotfix branch to fix the coding issue. 3436310-coding-fix.

Please review it.

  • yas committed f3d26b71 on 7.x authored by baldwinlouie 
    Issue #3436310 by baldwinlouie, yas: Hotfix - Support modal delete...

  • yas committed 825aa650 on 6.x authored by baldwinlouie 
    Issue #3436310 by baldwinlouie, yas: Hotfix - Support modal delete...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Fixed

@baldwinlouie

Thank you for the fix for the coding standard. I'll merge the patch to 6.x and 7.x; and close this issue as Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.