Problem/Motivation
Header component has a "morning" version which turn it :
Lors des périodes de deuil national, il est possible d’utiliser la version en berne du header, en ajoutant à la balise l’attribut data-fr-mourning. La Marianne s’affichera alors dans sa version en berne.
https://www.systeme-de-design.gouv.fr/elements-d-interface/composants/en...
It is not a prop of header component because:
- the attribute is expected outside the component markup
- the attribute also alter footer component
It is a theme/mode, like light & dark, and mist be implemented with UI Skins
Proposed resolution
It will be a bit more complicated than expected, because data-fr-mourning is not replacing data-fr-scheme but used along it.
So, there are not 1 but 2 themes: "Mourning light" and "Mourning dark". Maybe 3 with "Mourning system"
Each one of those themes must be activated with the corresponding theme, so has a dependency on it:
mourning_system:
label: "Mourning system"
key: data-fr-mourning
target: html
value: ''
dependencies:
- system
mourning_light:
label: "Mourning light"
key: data-fr-mourning
target: html
value: ''
dependencies:
- light
mourning_dark:
label: "Mourning dark"
key: data-fr-mourning
target: html
value: ''
dependencies:
- darkHowever, this dependency system is not implemented yet in UI Skins, so this issue is postponed.
Issue fork ui_suite_dsfr-3435831
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
pdureau commentedComment #3
yassrzg commentedComment #4
yassrzg commentedComment #6
pdureau commentedComment #7
pdureau commentedLet's wait until UI Skins 1.0.0-alpha7 is released
Comment #8
pdureau commentedComment #9
pdureau commentedhttps://www.drupal.org/project/ui_skins/releases/1.1.0-alpha1 was released with: "#3435933 by yassrzg, Grimreaper, pdureau: Introducing dependencies between themes"
Comment #10
pdureau commentedComment #11
pdureau commentedMaybe the current MR is already enough. I will have a look.
Comment #13
pdureau commented