Problem/Motivation

Header component has a "morning" version which turn it :

Lors des périodes de deuil national, il est possible d’utiliser la version en berne du header, en ajoutant à la balise l’attribut data-fr-mourning. La Marianne s’affichera alors dans sa version en berne.

https://www.systeme-de-design.gouv.fr/elements-d-interface/composants/en...

It is not a prop of header component because:

  • the attribute is expected outside the component markup
  • the attribute also alter footer component

It is a theme/mode, like light & dark, and mist be implemented with UI Skins

Proposed resolution

It will be a bit more complicated than expected, because data-fr-mourning is not replacing data-fr-scheme but used along it.

So, there are not 1 but 2 themes: "Mourning light" and "Mourning dark". Maybe 3 with "Mourning system"
Each one of those themes must be activated with the corresponding theme, so has a dependency on it:

mourning_system:
  label: "Mourning system"
  key: data-fr-mourning
  target: html
  value: ''
  dependencies:
   - system

mourning_light:
  label: "Mourning light"
  key: data-fr-mourning
  target: html
  value: ''
  dependencies:
   - light

mourning_dark:
  label: "Mourning dark"
  key: data-fr-mourning
  target: html
  value: ''
  dependencies:
   - dark

However, this dependency system is not implemented yet in UI Skins, so this issue is postponed.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

pdureau created an issue. See original summary.

pdureau’s picture

Category: Task » Feature request
yassrzg’s picture

Assigned: Unassigned » yassrzg
Status: Postponed » Needs work
yassrzg’s picture

Status: Needs work » Needs review

pdureau’s picture

Title: Add mourning theme/mode » [beta7] Add mourning theme/mode
pdureau’s picture

Status: Needs review » Postponed

Let's wait until UI Skins 1.0.0-alpha7 is released

pdureau’s picture

Title: [beta7] Add mourning theme/mode » [1.1.0] Add mourning theme/mode
pdureau’s picture

Status: Postponed » Needs work

https://www.drupal.org/project/ui_skins/releases/1.1.0-alpha1 was released with: "#3435933 by yassrzg, Grimreaper, pdureau: Introducing dependencies between themes"

pdureau’s picture

Title: [1.1.0] Add mourning theme/mode » [1.0.2] Add mourning theme/mode
pdureau’s picture

Assigned: yassrzg » pdureau
Status: Needs work » Needs review

Maybe the current MR is already enough. I will have a look.

pdureau’s picture

Assigned: pdureau » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.