Header, footer & page layout

Left and sidebar: add container

We have those 2 regions:

  sidebar_first: Sidebar - First
  sidebar_second: Sidebar - Second

They are printed in page.html.twig

However, they are not displayed as proper sidebars. We need to use the DSFR grid into page.html.twig

Useless page.logo variable?

in page.html.twig, there is a page.logo variable:

  {{ pattern('header', {
    'logo_text': page.logo,

But there are no "logo" region:

regions:
  header_operator_logo: Header - Operator logo
  header_tools_links: Header - Tools links
  header_tools_search: Header - Tools search
  header_navbar: Header - Navbar
  content: Content
  sidebar_first: Sidebar - First
  sidebar_second: Sidebar - Second
  footer_operator_logo: Footer - Operator logo
  footer_content: Footer - Content
  footer_content_desc: Footer - Content description
  footer_partners: Footer - Partners
  footer_bottom: Footer - Bottom
  footer_bottom_copy: Footer - Bottom copy

We don't want such a region, because logo_text is a string prop, not a slot.

header & footer: configurable logo_text

The replacement value of logo_text will be taken from a new textfield theme setting.

Default value for container in theme settings?

After the installation of the theme, there is no container. Would it look cleaner to have the fixed container by default?

Issue fork ui_suite_dsfr-3432748

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

pdureau’s picture

pdureau commented
Issue summary: View changes

yassrzg made their first commit to this issue’s fork.

yassrzg’s picture

yassrzg commented
Assigned: Unassigned » yassrzg
Issue summary: View changes
Status: Active » Needs work

i take it

yassrzg opened merge request !60

yassrzg’s picture

yassrzg commented

remaining work : line break on logo_text

yassrzg’s picture

yassrzg commented
Status: Needs work » Needs review
pdureau’s picture

pdureau commented
Status: Needs review » Reviewed & tested by the community
pdureau’s picture

pdureau commented
Title: [beta7] Some little fixes in header, footer & page layout » [beta6] Some little fixes in header, footer & page layout

Let's move this to beta6

pdureau’s picture

pdureau commented
Assigned: yassrzg » Unassigned

  • pdureau committed 013ae9bc on 1.0.x authored by yassrzg 
    Issue #3432748 by yassrzg: Little fixes in header, footer & page layout
pdureau’s picture

pdureau commented
Status: Reviewed & tested by the community » Fixed

  • pdureau committed 2480fb66 on 1.0.x 
    Issue #3432748 by pdureau: Default value for logo_text

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.