Problem/Motivation
There is a new CSPELL job in the gitlab pipeline and it reports some spelling errors and unrecognized part words. This results in a warning and the pipeline end amber.
We can fix these to get the pipeline passing green again.
Issue fork module_filter-3431234
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
jonathan1055 commentedI am going to use this issue as test for the upcoming gitlab_templates changes on #3426136: Execute CSPELL in project root folder and make fixing words easier
Comment #3
jonathan1055 commentedBaseline starting point is
Comment #4
jonathan1055 commentedThe first commit adds a word, but without extra quotes.
The job should fail as this is currently incorrect syntax with the existing cspell job.
Comment #6
jonathan1055 commentedAs expected we get the failure
https://git.drupalcode.org/issue/module_filter-3431234/-/jobs/1092051
Next commit will use the changes in the gitlab_templates MR155
Comment #7
jonathan1055 commentedWith MR155 the cspell jobs runs correctly.
https://git.drupalcode.org/issue/module_filter-3431234/-/jobs/1092554
42 files checked instead of 43. Composer.json is now automatically ignored. The single word 'nana' in _CSPELL_WORDS is no longer reported.
Comment #8
jonathan1055 commentedThe last commit added two more words and ignored the 'maintainers' paragraph in README.md
Comment #9
jonathan1055 commentedAdded two drupal/programming terms
ctools, interdifto _cspell_words, and changed two variable names to camelCase.https://git.drupalcode.org/issue/module_filter-3431234/-/jobs/1093117
Now we are just left with the real spelling errors:
Comment #10
jonathan1055 commentedThe cspell job passes green
https://git.drupalcode.org/issue/module_filter-3431234/-/jobs/1093197
Comment #11
jonathan1055 commentedThe spelling fixes are all done, but this is still using the MR155 from gitlab_templates issue #3426136: Execute CSPELL in project root folder and make fixing words easier
We need to wait for that to be merged, and then also wait for those changes to reach the 'default-ref' tag, which is the equivalent of a stable recommended release.
Comment #12
jonathan1055 commented#3426136: Execute CSPELL in project root folder and make fixing words easier has been committed.
Also the gitlab_templates
default-reftag has been updated to include this change for all contrib by default. Hence I have reverted the temporary change here.The CSPELL job ends green. This is ready for review.
Comment #14
smustgrave commentedFine with all the word changes. Didn't think about the disable for the names I've added my name to the cpsell ignore txt file on other projects haha.
Comment #15
smustgrave commentedUnchecking myself.
Comment #16
jonathan1055 commentedNice to see the green pass.