Problem/Motivation

Webform includes a test feature / tab that pre-fills the fields in the form with valid values so you can quickly send in a test submission. This does not work with the phone number field. Currently the number sub-field is empty and the extension field is filled with invalid data.

Steps to reproduce

Create a webform. Add a phone_number module phone field. Visit the test tab on the webform.

Proposed resolution

Improve our webform integration such that valid test values are supplied when the webform is in test mode.

Remaining tasks

Patch/MR & review.

User interface changes

Improved experience in webform admin.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#5 Afterpatch-20.png52 KBkanchan bhogade
#5 Beforepatch-20.png47.8 KBkanchan bhogade

Issue fork phone_number-3427719

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chrisolof created an issue. See original summary.

vaish made their first commit to this issue’s fork.

vaish opened merge request !20

vaish’s picture

vaish commented
Status: Active » Needs review
kanchan bhogade’s picture

kanchan bhogade commented
StatusFileSize
new Beforepatch-20.png47.8 KB
new Afterpatch-20.png52 KB

Hi
I've tested MR !20 on Drupal 10; the Issue is reproduced
The patch is applied successfully...

Testing Steps:

  1. Install Drupal Version
  2. Install and enable the webform Module
  3. Install and enable Phone No. (field) Module
  4. Go to structure -> webform -> add webform with phone No, field and save
  5. Go to the "Test tab" of the added webform and check for the "Phone no. field
  6. Apply the patch and check for the same

Test Result :
The number sub-field and the extension field have a valid Phone No.
RTBC+1

Adding SS for the reference

Keeping in "Needs review" for code verification

chrisolof’s picture

chrisolof
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. Thanks Vaish!

  • vaish committed 06443cce on 2.0.x 
    Issue #3427719 by vaish, Kanchan Bhogade, chrisolof: Webform test values...
vaish’s picture

vaish commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.