Problem/Motivation

PHPUnit 9 deprecated ::expectError*() and ::expectWarning*()methods. They're removed from PHPUnit 10.

Proposed resolution

  1. Deprecate passing TrustedCallbackInterface::TRIGGER_WARNING for $error_type in DoTrustedCallbackTrait::doTrustedCallback() in 10.3
  2. Remove the feature and the interface constant in D11

Issue fork drupal-3427178

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Assigned: Unassigned » mondrake

Working on this.

mondrake opened merge request !7011

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue summary: View changes
Status: Active » Needs review

MR!7011 is for 10.3.x. Once we confirm this is the way to go, I'd add a D11 branch for the removal, à la #3427173: Replace calls to :::expectWarning*() in Drupal\Tests\Component\PhpStorage\FileStorageTest.

smustgrave’s picture

smustgrave commented

Change looks fine to me. Do you want to open the 11.x branch also?

mondrake’s picture

mondrake
Location 🇮🇹
commented

I think this should wait until we have found a direction for #3427173: Replace calls to :::expectWarning*() in Drupal\Tests\Component\PhpStorage\FileStorageTest.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Assigned: mondrake » Unassigned
smustgrave’s picture

smustgrave commented
Status: Needs review » Postponed

Sounds good postponing on #3427173: Replace calls to :::expectWarning*() in Drupal\Tests\Component\PhpStorage\FileStorageTest

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Postponed » Needs work

I think we should go ahead and deprecate TRIGGER_WARNING. As far as I can see it was never used in core (except for the test coverage) and can't find any uses in contrib.

longwave opened merge request !7399

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review

MR!7011 for 10.3.x and MR!7399 for 11.x

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Removal seems fine, all green.

  • catch committed c8cfcf07 on 11.x 
    Issue #3427178 by mondrake, longwave: Replace calls to ::expectWarning...

  • catch committed a50c07aa on 10.3.x 
    Issue #3427178 by mondrake, longwave: Replace calls to ::expectWarning...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Commited/pushed to 11.x and 10.3.x respectively, thanks!

quietone’s picture

quietone commented
Issue tags: +Needs change record updates

There is a change record for this issue that consists of "@tbd"

catch’s picture

catch
he/him
Primary language English
commented
Issue tags: -Needs change record updates

Whoops. I updated the CR with how to handle the deprecation.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mondrake closed merge request !7011