Problem/Motivation

PHPUnit 9 deprecated ::expectError*() and ::expectWarning*()methods. They're removed from PHPUnit 10.

Proposed resolution

Replace trigger_error() with an exceptoin.

Issue fork drupal-3427172

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !7000

mondrake’s picture

mondrake
Location 🇮🇹
commented
Assigned: Unassigned » mondrake
Status: Active » Needs work
mondrake’s picture

mondrake
Location 🇮🇹
commented
Assigned: mondrake » Unassigned
Issue summary: View changes
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Wondering if this one also should just be an exception or assertion.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work
Related issues: +#2972003: Verify that the file name matches the ID when installing configuration

Originally added in #2972003: Verify that the file name matches the ID when installing configuration

At the time we were worried about breaking sites so it was "only" a warning in D8, I think we can upgrade this to an exception now for 11.x.

longwave opened merge request !7398

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue summary: View changes
Status: Needs work » Needs review

mondrake closed merge request !7000

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community

MR 7398 is a completely different approach from MR 7000, so I think I can RTBC it.

  • catch committed 29bebc73 on 11.x 
    Issue #3427172 by mondrake, longwave: Replace calls to ::expectWarning...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.