Closed (fixed)
Project:
Security Review
Version:
3.0.0-rc4
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
11 Mar 2024 at 02:01 UTC
Updated:
30 Mar 2024 at 03:44 UTC
Jump to comment: Most recent
Hey all... upgraded from 2.0 to 3.0. On first security scan, it freezes at file permissions (4 of 18), and I get this guzzle error.
GuzzleHttp\Exception\ClientException: Client error: `GET https://sitename.com` resulted in a `401 Unauthorized` response in GuzzleHttp\Exception\RequestException::create() (line 113 of /home/public_html/vendor/guzzlehttp/guzzle/src/Exception/RequestException.php).
Tried reinstalling, a new composer require with-dependencies, etc. No help. Any suggestions? Am i missing something simple?
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
eelkeblokPresumably, sitename.com is the site you are scanning? Is there anything in the logs? I'd be especially interested in the stack trace. I'm guessing this might in fact be the next scan, because the file permissions do not involve an HTTP request (other than that from your browser to run the batch iteration). Just not sure which one that would be. Maybe the Headers one.
Comment #3
smustgrave commentedWonder if it's the headers check.
Comment #4
smustgrave commented@chucksimply if you disable that one check does it run now?
Also know of any firewall that may be blocking your site from hitting itself to check headers?
Comment #5
eelkeblokI was thinking the same thing. I had a peek at the code in the Headers scan and I believe it should pass an option to Guzzle to not throw exceptions for "error" codes (it's in the documentation, don't remember the details). Or, alternatively, catch any exceptions Guzzle might throw (but IIRC that can be a little tricky; you'd need to catch a base exception that all other exceptions derive from, for our purposes).
Comment #6
smustgrave commentedLets do that
Comment #8
smustgrave commentedThoughts?
Comment #9
eelkeblokLooks good. If @chucksimply could do a functional test, that would be swell.
Comment #11
smustgrave commentedIf we need to reopen we can no problem. Lets get that 3.0.0 release out :)
Comment #12
chucksimply commentedThanks all for the quick work. New release tested and works great!