Problem/Motivation

If you go to Content > Media, you have a full pager.
If you go to Content > Media > Grid, you have a mini pager.

I think this should be the same for consistency.

Steps to reproduce

1. Install media and media_library.
2. Use devel_generate to generate 50 media items.
3. Go to /admin/content/media and observe the full pager.
4. Go to /admin/content/media-grid and observe the mini pager.

Proposed resolution

Use mini pager on both.

Remaining tasks

Discuss.

User interface changes

Display mini pager instead of the full pager in view "Media" (core/modules/media/config/optional/views.view.media.yml)

API changes

None.

Data model changes

None.

Release notes snippet

Media library Views (core/modules/media/config/optional/views.view.media.yml) now uses the mini pager option for consistency.

CommentFileSizeAuthor
#6 issue_3426699_media-library-pager_7424-01.patch1.39 KBtheodorosploumis

Issue fork drupal-3426699

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

penyaskito created an issue. See original summary.

adwivedi008 made their first commit to this issue’s fork.

vensires’s picture

vensires
Location Greece
commented
Issue tags: +GreeceSpringSprint2024
theodorosploumis’s picture

theodorosploumis
he/him
Location Greece
commented
Assigned: Unassigned » theodorosploumis

TheodorosPloumis opened merge request !7424

theodorosploumis’s picture

theodorosploumis
he/him
Location Greece
commented
Title: Media library and media views should use same pager for consistency » Media library and media views should use both mini pager for consistency
Issue summary: View changes
StatusFileSize
new issue_3426699_media-library-pager_7424-01.patch1.39 KB

I think that mini pager is the better option here. The main reasons for this decision are:

1) Consistency, as mentioned on the issue title.
2) Performance. Mini pager is less heavy than the full pager.
3) Usability. Media are usually attached to Nodes. So navigating to the first or last item is not something really important.

theodorosploumis’s picture

theodorosploumis
he/him
Location Greece
commented
Title: Media library and media views should use both mini pager for consistency » Media library and media views should both use the mini pager for consistency
Issue tags: +media library
theodorosploumis’s picture

theodorosploumis
he/him
Location Greece
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

I’m actually of the opposite mindset and think both should use full. We use full on block content and content views

What’s the reason to use mini vs fill?

vensires’s picture

vensires
Location Greece
commented

@smustgrave, I think that the points already addressed by @theodorosploumis in #6 is the answer you are looking for:

1) Consistency, as mentioned on the issue title.
2) Performance. Mini pager is less heavy than the full pager.
3) Usability. Media are usually attached to Nodes. So navigating to the first or last item is not something really important.

Feel free to express your objection on the previous points though.

I leave this as Needs Work because I'm not 100% sure the patch and the MR are in accordance.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.