Problem/Motivation

Provide tests for ShortcutsNavigationBlock plugin.

Issue fork navigation-3426575

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

plopesc created an issue. See original summary.

plopesc opened merge request !186

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Active » Needs review

MR created

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Title: Add tests for ShortcutsNavigationBlock » [PP-1] Add tests for ShortcutsNavigationBlock
Status: Needs review » Needs work
Related issues: +#3426626: ShortcutsNavigationBlock is not being cached properly

Postponed on #3426626: ShortcutsNavigationBlock is not being cached properly

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs work » Postponed

plopesc closed merge request !186

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Title: [PP-1] Add tests for ShortcutsNavigationBlock » Add tests for ShortcutsNavigationBlock
Status: Postponed » Active

Back to active once the blocker issue has been already fixed.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Active » Needs review

MR ready for review.

Part of the test is commented because are related to shortcut module caching issues that are not fixed in 10.2.x

Once tests are run against 10.3.x or 11.x, they'll be necessary.

m4olivei made their first commit to this issue’s fork.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Needs review » Reviewed & tested by the community

Looks great! Thanks.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Reviewed & tested by the community » Fixed

Merged to 1.x 🎉

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.