Problem/Motivation
We're currently on 40.2.0, since #3406732: Update CKEditor 5 to 40.2.0 on December 13, 2023.
CKEditor 5 has released:
- 41.0.0 on Jan 17, 2024: https://github.com/ckeditor/ckeditor5/releases/tag/v41.0.0
- 41.1.0 on Feb 7, 2024: https://github.com/ckeditor/ckeditor5/releases/tag/v41.1.0
- 41.2.0 on March 6, 2024: https://github.com/ckeditor/ckeditor5/releases/tag/v41.2.0
Changes that likely impact Drupal:
- minor breaking change in 41.0.0 that likely breaks contrib modules:
engine: Renamed export of the View class to EditingView. See #15511.→ this is why a single change in Drupal core's CKEditor 5 plugins was required this time around: https://git.drupalcode.org/project/drupal/-/merge_requests/6832/diffs?co... - minor breaking change in 41.0.0:
link: Added validation to the URL field to disallow empty URLs by default. See #12501.→ this is the behavior we've been expecting for years, so this is good to see: no more nonsensically empty links (<a href="">ceci n'est pas un lien!</a>) — see https://github.com/ckeditor/ckeditor5/issues/12501
Proposed resolution
- Update
core/package.json yarn --cwd core install && yarn --cwd core build && yarn --cwd core build:ckeditor5-typesgit add core/assets/vendor/ckeditor5(to ensure newly added files, typically translations, are also committed)
Remaining tasks
None.
User interface changes
None.
API changes
None.
Data model changes
None.
Release notes snippet
CKEditor 5 has been updated to 41.2.0
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | deprication-notices.png | 146.75 KB | jannakha |
Issue fork drupal-3424644
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3424644-cke5-41
changes, plain diff MR !6832
- 3424644-extratranslations
changes, plain diff MR !7052
Comments
Comment #2
wim leersCopy/paste leftover 🤣
Comment #3
wim leersBased on the results from January 29 over at #3379104-35: Add a "CKEditor 5 nightly" GitLab CI job, I already know tests will fail. 😮💨
Comment #5
wim leersWell that was easy 😄
Comment #6
wim leersIn a meeting with the CKEditor 5 team just now, there's going to be a
41.2.0release next week, so let's wait for that 👍Comment #7
wim leersComment #8
wim leershttps://github.com/ckeditor/ckeditor5/releases/tag/v41.2.0 is out 👍
Some very interesting new things:
link: Added the ability to specify allowed URL protocols by introducing the link.allowedProtocols configuration property. Closes #14304. (commit)-> doesn't really affect us because the default (only allowing HTTP/HTTPS/MAILTO) has served us fine so far. But a contrib/custom module may have additional needs, so then this makes sense 👍html-support: Background color style should be properly preserved by GHS while the FontBackgroundColor plugin is enabled. It should also be able to preserve a partly defined style. Closes #15757, #10399. (commit)→ I'm sure this will help sites with … more "complex" contentpaste-from-office: It now should be possible to paste charts from Microsoft Word. Closes #15758. (commit)→ surely an important fix for somesource-editing: Source editing should not add whitespaces to the pre-formatted code lines. Closes #15084. (commit)→ reported by yours truly: https://github.com/ckeditor/ckeditor5/issues/15084 🤓Comment #9
wim leersComment #11
jannakha commentedMR is applied and working well.
Some deprecation notices in console:

Updated MR to fix deprecation notices:
https://ckeditor.com/docs/ckeditor5/latest/api/module_list_documentlistp...
Question:
new AccessibilityHelp component of CKEditor - how should that be implemented? Added to the core just like other components? or a separate contrib module?
Question:
Is this going to be backported to D10.2/3?
Comment #12
wim leers@jannakha Ohhhh! Well-spotted! Thank you 🫣🙏😄
RE:
AccessibilityHelp: I contemplated doing that. I was thinking it'd be preferred to do that in a follow-up issue, because we may want to change the Standard install profile's default text editors to have this button enabled by default…RE: 10.2/10.3: this will land in 10.3 for sure, because 10.3.0 has not been released yet. This will not be backported to 10.2.0, because it's a major version bump of CKEditor 5, and includes breaking changes.
Comment #13
jannakha commented@Wim Leers!
awesome! I'll test this MR more on my sites to get this released sooner!
I've created a new task for AccessibilityHelp so it can be developed independently from this issue: https://www.drupal.org/project/drupal/issues/3427039
Comment #14
wim leersThanks, @jannakha! Followed up on that issue.
This issue is now ready for RTBC — and I think @jannakha is uniquely qualified to do so, because she spotted the thing I overlooked! 😄👍
P.S.: are you on Drupal Slack? What's your username there? :)
Comment #15
smustgrave commentedSo I applied the MR locally this morning.
Did some content creation in the ckeditor, using all the buttons I can.
I see drupalmedia changed so I tested embedding media bundles in the ckeditor and that was still working for me.
Update seems fine +1, but will leave in review for additional eyes.
Comment #16
smustgrave commentedTested again today and still not seeing any regression.
Comment #19
catchThanks for the testing, makes sense to get this in asap so it's available during the alpha and later. Added to the 10.3.0 release notes draft.
Committed/pushed to 11.x and cherry-picked to 10.3.0, thanks!
Comment #20
finnsky commentedSeems also translations should be added
After i runned yarn build
https://gyazo.com/33ccb78419f7a2dc0588b527b88d2bcf
Comment #22
catchComment #23
wim leersOh weird … you're right: 🫣
Comment #24
wim leersThe
testUnmanagedGitIgnoreWhenGitNotAvailablefailure is happening all across core; that's unrelated to this MR.Repeated #23 locally on top of the branch that @finnsky pushed, and confirmed that I get identical results.
⚠️ I've updated the issue summary to ensure the next CKEditor 5 update doesn't repeat this mistake.
Comment #27
catchCommitted/pushed to 11.x and cherry-picked to 10.3.x, thanks!
Comment #29
quietone commentedRemoving tag because CKEditor was updated later, #3443567: Update CKEditor 5 to 41.3.1