Hey everyone,

After the update to the 3.0.5 version I noticed in my project that the status messages lost the "close" button. I checked the code and it seems the closing button is missing from the twig template found in templates/misc. Not sure if this is a bug or intentional

CommentFileSizeAuthor
#13 Issue-3424347-after.png228.39 KBsandip
#13 Issue-3424347-before.png212.09 KBsandip
#9 Issue.jpg192.99 KBsandip
#2 add_close_button-3424347-2.patch602 bytesnsalves

Issue fork bootstrap4-3424347

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nsalves created an issue. See original summary.

nsalves’s picture

nsalves commented
StatusFileSize
new add_close_button-3424347-2.patch602 bytes

Here's a patch to add the missing button on twig based on what was previously available on 2.1.x

utkarsh_kumar_singh’s picture

utkarsh_kumar_singh commented
Assigned: Unassigned » utkarsh_kumar_singh

I am working on it.

utkarsh_kumar_singh opened merge request !16

utkarsh_kumar_singh’s picture

utkarsh_kumar_singh commented
Assigned: utkarsh_kumar_singh » Unassigned
Status: Active » Needs review

Add the closing button in the status messages. The patch file above mentioned was not working after apply, so I had to change the some code in css and js.

utkarsh_kumar_singh’s picture

utkarsh_kumar_singh commented
Status: Needs review » Needs work

I accidently pushed the some files those are not required. So I am assinging it to my self.

utkarsh_kumar_singh’s picture

utkarsh_kumar_singh commented
Assigned: Unassigned » utkarsh_kumar_singh
utkarsh_kumar_singh’s picture

utkarsh_kumar_singh commented
Assigned: utkarsh_kumar_singh » Unassigned
Status: Needs work » Needs review

Sorry for my mistakes. Now the latest commit is final commit.

sandip’s picture

sandip commented
Status: Needs review » Needs work
StatusFileSize
new Issue.jpg192.99 KB

Hi @utkarsh_kumar_singh,

Thank you for your contribution! I appreciate your efforts on this. However, I have a few doubts that I’d like to clarify:

In your MR, I noticed that you added custom JavaScript for closing the status message. This isn’t necessary, as applying the relevant patch should address the issue effectively.

The main concern I observed is that the status message block isn’t rendering from the status-messages.html.twig file provided in the theme. This needs to be fixed. Could you please work on this?

I’m updating the issue status to NW for now. Let me know if you need any assistance!

IMG

utkarsh_kumar_singh’s picture

utkarsh_kumar_singh commented
Assigned: Unassigned » utkarsh_kumar_singh

Thank You @sandip poddar for your suggestions. I am working on it.

sandip’s picture

sandip commented

For your reference you can see this core issue queue https://www.drupal.org/project/drupal/issues/3456176#comment-15738200

utkarsh_kumar_singh’s picture

utkarsh_kumar_singh commented
Assigned: utkarsh_kumar_singh » Unassigned
Status: Needs work » Needs review

Fixed the issue.

sandip’s picture

sandip commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Issue-3424347-before.png212.09 KB
new Issue-3424347-after.png228.39 KB

LGTM Thanks :)
I am attaching before and after ss for clarification.
Moving to RTBC++.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution. 🍻
Committed.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • vladimiraus committed d187d08f on 3.0.x 
    feat: #3424347 Closing button missing from the status message twig

By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.