Problem/Motivation

"use script" shouldn't be in the global scope.

Proposed resolution

Removed "use script" from global scope.

CommentFileSizeAuthor
#2 orejime_register-use_strict_removed_from_global_scope-3424148.patch402 byteslleytere

Issue fork orejime_register-3424148

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Lleytere created an issue. See original summary.

lleytere’s picture

lleytere commented
StatusFileSize
new orejime_register-use_strict_removed_from_global_scope-3424148.patch402 bytes
nicocin’s picture

nicocin commented

A merge would be very appreciated ;)

jmaxant’s picture

jmaxant commented
Status: Active » Reviewed & tested by the community
jmaxant’s picture

jmaxant commented
Status: Reviewed & tested by the community » Needs work

I kinda jumped the gun here, the patch is ok but I guess we need a proper MR for merging. I'll roll it later this week if no one does until then.

atul_ghate made their first commit to this issue’s fork.

atul_ghate opened merge request !1

atul_ghate’s picture

atul_ghate commented
Status: Needs work » Needs review

martygraphie’s picture

martygraphie commented
Assigned: Unassigned » martygraphie
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.