Problem/Motivation

statistics_node_translation_counter migration is in the content translation module.

Steps to reproduce

Proposed resolution

move it to statistics

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3424009

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !6785

quietone’s picture

quietone commented
Version: 10.3.x-dev » 11.x-dev
Status: Active » Needs review

Ready for review

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Change makes sense and needed to deprecate statistics probably.

  • catch committed 70889f50 on 10.3.x 
    Issue #3424009 by quietone: Move statistics_node_translation_counter to...

  • catch committed 686803df on 11.x 
    Issue #3424009 by quietone: Move statistics_node_translation_counter to...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

quietone’s picture

quietone commented

I realized this morning that moving a multi-lingual migration out of content_translation might cause problems because they were placed in content_translation so they were not discovered.

I did some local testing and confirmed that the statistics_node_translation_counter is now discovered when content_language is not installed. Ideally, that should not happen but it is working as designed.

This means that this translation related migration will always run when using the 'one click' upgrade or similar drush command. Fortunately, that does not cause errors because this migration is to support the Classic node migrations. The 'one click' upgrade uses the Node Complete migrations where d6_node_translation and d7_node_translation are not used. When statistics_node_translation_counter runs every row will be skipped because migration_lookup will return a NULL.

  nid:
    -
      plugin: migration_lookup
      migration:
        - d6_node_translation
        - d7_node_translation
      source: nid
    -
      plugin: skip_on_empty
      method: row
    -
      plugin: extract
      index:
        - 0

quietone closed merge request !6785

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.